Attention is currently required from: jolly, dexter.
View Change
1 comment:
File src/common/bts.c:
Patch Set #6, Line 726: int is_nch_res, int is_ag_res
If is_nch_res is set, the message to be sent is an NCH message on NCH. […]
Thanks for explaining. Still, IMO an enum would be a better fit here:
```
CCCH_MSGT_NCH,
CCCH_MSGT_PCH,
CCCH_MSGT_AGCH,
```
To view, visit change 33297. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa
Gerrit-Change-Number: 33297
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jul 2023 17:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas@eversberg.eu>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment