Attention is currently required from: jolly, pespin.

View Change

2 comments:

• File src/osmo-bts-trx/sched_lchan_tchf.c:

  • Patch Set #2, Line 541: * - If the channel mode is AMR, transmit a dummy with speech

    I'd document here the rationale about "FACCH displaces two speech frames rather than one".

    This is not specific to TCH/AHS at all, and is already briefly mentioned in the existing code. It's also just one of the reasons; another reason is that some Qualcomm basebands don't seem to like dummy FACCH and report bad RxQual.

    So I would be fine with the current state of this patch.

  • Patch Set #2, Line 578: dummy_facch:

    Maybe moving the GSM48_CMODE_SPEECH_AMR case inside the default with an "if" block is cleaner than a […]

    Alternatively, we can move generation of dummy FACCH into a `static inline` function (`src/osmo-bts-trx/sched_utils.h` would be a good place for it) and just call it, hoping that the compiler would inline it properly for us.

To view, visit change 35132. To unsubscribe, or for help writing mail filters, visit settings.