Attention is currently required from: iedemam, laforge.
Patch set 2:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #2:
Well, that's an embarrassing result after such a long review process on my patch. […]
it's usually the test suite that catches obscurely appearing bugs.
it can help to run the ttcn3 tests locally, but things regularly get caught by jenkins.
i've added you to the group of reviewers.
Please skim this, it defines how we work with +1 and +2 votes:
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Voting-Rules-for-merging-a-patch-to-master
To view, visit change 28061. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I901bb86a78d7d021c8efe751fd9d93e5956ac0e0
Gerrit-Change-Number: 28061
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: iedemam <michael@kapsulate.com>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: iedemam <michael@kapsulate.com>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Fri, 06 May 2022 15:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: iedemam <michael@kapsulate.com>
Gerrit-MessageType: comment