Attention is currently required from: neels, pespin.

View Change

1 comment:

• File include/osmocom/gsm/gsm0502.h:

  • Patch Set #1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58

    ok, still if you use this after a division you'll have problems: […]

    Thanks for explanation. Now I see what could go wrong, even though it's unlikely that anyone will ever need to use these constants as a divisor. I wanted to understand potential pitfalls of not having braces rather than applying code review suggestions blindly. Will add the braces.

To view, visit change 31669. To unsubscribe, or for help writing mail filters, visit settings.