Attention is currently required from: falconia, fixeria, jolly, laforge.

2 comments:

Patchset:
- Patch Set #6:
  Other than the public structs discussion, other stuff looks good to me already.
File include/osmocom/netif/twjit.h:
- Patch Set #6, Line 50: struct osmo_twjit_config {
  The only thing left which I'm now concerned is regarding exposing all these structs here, which means extending them later on would break the ABI.
  Hence, my proposal (I'm happy to discuss or get back other proposals):
  - Add setter APIs for fields in struct osmo_twjit_config, eg:
```
    int osmo_twjit_set_bd_start(struct osmo_twjit *twjit, uint16_t bf_start);
```
  - osmo_twjit_stats: Have an API to obtain stats based on a enum,similar to getsocktopt. eg:
```
    uint32_t rx_packets;
    int osmo_twjit_get_stat_(twjit, OSMO_TWJIT_STAT_RX_PACKETS, &rx_packets)
    
* osmo_twjit_rr_info: Probably the same as osmo_twjit_stats?
```

To view, visit change 39280. To unsubscribe, or for help writing mail filters, visit settings.