Attention is currently required from: Hoernchen, Timur Davydov, fixeria, osmith.
View Change
1 comment:
Patchset:
Patch Set #1:
For Emscripten I’m actually building them as static libraries. […]
If we are linking dynamically against the stuff in CommonLibs/ and GSM/ then I'd say it's unintended.
If that's the case, please submit a patch to always statically link those files into osmo-trx-*.
I see no need for the .pc files since those object files are not expected to be used by other programs, they are internal to osmo-trx.
To view, visit change 42243. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp@gmail.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 15:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp@gmail.com>