Attention is currently required from: fixeria, laforge, pespin.

View Change

1 comment:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    After looking at the follow up commit, I also understand now what @vyanitskiy@sysmocom.de means. […]

    I see your point. However, this would change the original behavior.

    Before splitting the code, when an invalid timeslot was provided, ctrl_sock_handle_rx() would return 0 and exit the function, so no response was sent. If we keep returning 0 after the refactoring, the command would now be answered, which was not the case before.

    So this would slightly change the original logic.

To view, visit change 42421. To unsubscribe, or for help writing mail filters, visit settings.