Attention is currently required from: arehbein, daniel, fixeria, laforge.
View Change
1 comment:
File src/osmo_ss7_asp.c:
Patch Set #8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb);
There is nothing TCP specific about this callback. […]
So can you name any of them which is not TCP? which is using the exact same header approach used by this callback?
Having the "tcp" prefix would help immediatelly understand to the reader that this callback is used when passing data tcp -> M3UA, instead of trying to figure out what this callback is for.
To view, visit change 35070. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 8
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 19:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment