Attention is currently required from: dexter.

Patch set 3:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #3, Line 9: call agent

    by call agent, do you mean like BSC and MSC? So far I see call agent as meaning a PBX like freeswitch or kamailio. Maybe 'MGCP client'?

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #3, Line 1168: DEBUG

    I guess when we drop packets that would be LOGL_ERROR; only problem is with spamming 20 LOGL_ERROR per second... so maybe NOTICE? definitely DEBUG seems too insignificant when this is the single point of failure for establishing a voice call.

    (I was thinking before about a mechanism in the MGW, where we sort of remember that previous RTP packets of an endp had identical errors, and we log an error only once, or maybe only once every ten seconds. Just thinking here, does not need to be part of this patch.)

To view, visit change 32290. To unsubscribe, or for help writing mail filters, visit settings.