Attention is currently required from: laforge.

laforge uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Verified-1 by Jenkins Builder

osmo_stream_cli_send(): Drop data if client is not connected [yet]

The behaviour is undefined on what should happen if a stream client user
is trying to write data before the client socket is connected. In
osmo_io mode we would actually crash due to a NULL-pointer dereference.

Let's discard any sent data in this situation and print a related error log message.

This problem actually shows up with osmo-bsc Change-Id
Icce412e6ee69366c7b131c9bc1d51e8d44204917 where we convert CBSP over to
osmo_io - here in situations where a CBSP client (using stream_cli) was
previously connected but has lost its connection.

Change-Id: I18d2e8e850c23a32f5983a715fa8a18747b296cd
---
M src/stream_cli.c
1 file changed, 28 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/44/36244/2

To view, visit change 36244. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I18d2e8e850c23a32f5983a715fa8a18747b296cd
Gerrit-Change-Number: 36244
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-MessageType: newpatchset