Attention is currently required from: neels, laforge, fixeria.
6 comments:
Commit Message:
Patch Set #1, Line 9: It looks like T23042 was a placeholder for timers to be filled in later,
let me assure you that i invented this number explicitly as a placeholder, please don't even conside […]
Done
Patch Set #1, Line 15: Previous timeout for the states was 5s.
", from using the default of 5 for undefined timers. […]
Done
"immediately"
Done
Patch Set #1, Line 28: * Use new X29, 10s (5s from X5 + 5s from X6)
I think the right thing here is to remove this timeout; this needs no timeout at all because we can […]
Done in https://gerrit.osmocom.org/c/osmo-bsc/+/31339
Patch Set #1, Line 46: * Use new X30, 5s
I've added two TTCN-3 tests that let OsmoBSC go into the code paths where 1) the RSL CRCX isn't answered and 2) the MGCP MDCX is not answered. In both cases, the three second timer T3101 for LCHAN_ST_WAIT_RLL_RTP_ESTABLISH caused the handover to fail.
1) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31338
2) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31336
Then if I'm correct we should see during that test a log error like "HO_EV_LCHAN_ERROR not permitted" in state HO_ST_WAIT_LCHAN_ESTABLISHED.
To my surprise this did not show up. The reason is:
.allstate_event_mask = 0
| S(HO_EV_CONN_RELEASING)
| S(HO_EV_LCHAN_ERROR)
,
I've added a separate patch to remove T23042 for HO_ST_WAIT_LCHAN_ESTABLISHED: https://gerrit.osmocom.org/c/osmo-bsc/+/31340
File src/osmo-bsc/net_init.c:
Patch Set #1, Line 77: { .T = -30, .default_val = 5, .desc = "Timeout for establishing new lchan at the end of handover" },
(if X30 needs to stay, i'd put a desc = "Timeout for establishing MGW endpoint for handover target l […]
not needed
To view, visit change 30307. To unsubscribe, or for help writing mail filters, visit settings.