Attention is currently required from: fixeria.

View Change

1 comment:

• File src/osmocom/utils.py:

  • Patch Set #2, Line 151: other

    `... […]

    I was under the impression that the builtin "dunder" method return values are never type-annotated. Otherwise you'd probably have to annotate every __init__ etc? Not sure if there's a PEP about that.

    As for the "other": I was thinking of Union[hexstr,str], but as the former is a subclass of the latter, str would work. Will make that chagne.

To view, visit change 38023. To unsubscribe, or for help writing mail filters, visit settings.