Attention is currently required from: markb, fixeria.
View Change
1 comment:
File requirements.txt:
Patch Set #4, Line 13: packaging
And AFAICS, you are using this module in previous patch, but adding the dependency here. […]
Oh 3 places to add dependencies... I can see there are also other packages that were forgotten. (i have fixed this in a follow up patch)
To view, visit change 32533. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: markb <markboldyrev@gmail.com>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: markb <markboldyrev@gmail.com>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 13:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment