Attention is currently required from: neels, fixeria, lynxis lazus.

View Change

2 comments:

• File src/osmo-bsc/nm_bb_transc_fsm.c:

  • Patch Set #1, Line 345: case NM_EV_RAMP_GO:

    I've implemented it together with a libosmocore (ignore_invalid_event_mask). […]

    I don't see why you'd need to add it in all FSM states. If the object is ENABLED that means the configuration already went one and hence how it is possible that the outside code send this event to allow start of configuration?

• File src/osmo-bsc/nm_bts_fsm.c:

  • Patch Set #1, Line 92: struct gsm_bts *bts,

    IMHO this is fine. last example of 6.2) looks the same. […]

    You could check all the other configure_loop() functions and use the same format as in all of them ;)

To view, visit change 29788. To unsubscribe, or for help writing mail filters, visit settings.