Attention is currently required from: dexter.

2 comments:

File src/libosmo-mgcp/mgcp_codec.c:
- Patch Set #1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt)
  I don't think that this is good. I would find this parameter naming very confusing. […]
  Format conversion *is* transcoding :D
- Patch Set #1, Line 431: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the
  I do not see where this is not generic. […]
  I think that was precisely my point at the time (some weeks ago when I wrote my comment).
  I think you are mixing 2 things in the same function here:
  - Matching for the exact same codec (aka forwarding)
  - Matching if 2 codecs can be transcoded with current transcoding support.
  IMHO those are 2 different functions and they will differ more and more over time as we hopefully start supporting more transcoding at some point. Hence why it is really a good idea to already have 2 functions, not 1.

To view, visit change 27392. To unsubscribe, or for help writing mail filters, visit settings.