Attention is currently required from: dexter.
Patch set 10:Code-Review +1
View Change
1 comment:
File src/pcu_l1_if.cpp:
Patch Set #10, Line 277: if (imsi && strlen(imsi) >= IMSI_DIGITS_FOR_PAGING)
you are calling strlen(imsi) 3 times in this function.
To view, visit change 31650. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40d7fc14c9591b3de091e425faaf325421c70a0e
Gerrit-Change-Number: 31650
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 15:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment