Attention is currently required from: falconia.

View Change

2 comments:

• File src/common/vty.c:

  • Patch Set #5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) {

    tbh, I see no need for the global variable here.
    If at all, add a "#define RTP_LIBRARY_USE_TWRTP_DEFAULT true", but I don't even consider that necessary here.
    Simply do:

     if (bts->use_twrtp)
         vty_out(vty, " rtp library twrtp%s", VTY_NEWLINE);
         
    If you like, add a comment above it simply stating: "ortp is the default" or similar, nothing more is needed, see how it's done similarly for most of the other commands in here and other places.

  • Patch Set #5, Line 1529: vty_out(vty,

    I'd say simply add here:
        
        vty_out("RTP library: %s%s", bts->use_twrtp ? "Themyscira twrtp" : "Belledonne ortp", VTY_NEWLINE);

To view, visit change 42167. To unsubscribe, or for help writing mail filters, visit settings.