Attention is currently required from: osmith, laforge, fixeria.

View Change

1 comment:

• File src/osmo-bsc/bts_trx.c:

  • Patch Set #4, Line 355: if (!osmo_bts_has_feature(ft, BTS_FEAT_VAMOS)) {

    Not sure this check makes sense here. I would expect that all lchans to have 'vamos. […]

    that's correct.

    trx_has_valid_pchan_config() is only called when Abis comes UP or before.
    lchan.vamos.enabled is only set to true after chan activation.
    This entire 'if' is noop code.

To view, visit change 27923. To unsubscribe, or for help writing mail filters, visit settings.