Attention is currently required from: osmith, Hoernchen, neels, pespin, fixeria, daniel.

View Change

2 comments:

• File src/osmo_io.c:

  • Patch Set #3, Line 367: iofd->name = talloc_strdup(iofd, name);

    This can be split into a separate func osmo_iofd_set_name(), simplifying the current osmo_iofd_setup […]

    I actually think it is rather important to encourage all useres to provide a name. If it's a separate API call, it means many users will froget about it. Having meaningful names allows the osmo_io provider to do meaningful logging (with context) in error conditions, etc.

• File src/osmo_io_internal.h:

  • Patch Set #3, Line 87: // TODO: SCTP_*

    I'd say this needs to be added before merging the patch? or not needed?

    it is only needed later one when we start to support sctp_sendmsg/sctp_recvmsg, which are just API wrappers around normal sendmsg/recvmsg. But in order to provide the same level of API abstraction, we thought it would be good to offer a sctp_recvmsg callback for the applications. The TODO is therefore intentionally for a later follow-up patch.

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.