daniel has uploaded this change for review.

View Change

tcap_as_loadshare: Don't fill in PC from M3UA

If both calling and called_addr are not point codes then the compare in
tcap_trans_track_entry_find() will ignore them. It still matches on
otid/dtid.

Related: SYS#5423
Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9
---
M src/tcap_as_loadshare.c
1 file changed, 0 insertions(+), 24 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/84/42684/1

diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c
index f7ae3b8..635fd73 100644
--- a/src/tcap_as_loadshare.c
+++ b/src/tcap_as_loadshare.c
@@ -330,18 +330,6 @@
 		return 0;
 	}
 
-	/* TCAP transaction tracking requires point codes */
-	if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) {
-		/* use M3UA OPC instead */
-		calling_addr.pc = opc;
-		calling_addr.presence |= OSMO_SCCP_ADDR_T_PC;
-	}
-	if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) {
-		/* use M3UA DPC instead */
-		called_addr.pc = dpc;
-		called_addr.presence |= OSMO_SCCP_ADDR_T_PC;
-	}
-
 	/* retrieve the SCCP payload (actual encoded TCAP data) */
 	ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA);
 	if (!ie_data)
@@ -505,18 +493,6 @@
 		goto out_free_sua;
 	}
 
-	/* TCAP transaction tracking requires point codes */
-	if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) {
-		/* use M3UA OPC instead */
-		calling_addr.pc = mtp->opc;
-		calling_addr.presence |= OSMO_SCCP_ADDR_T_PC;
-	}
-	if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) {
-		/* use M3UA DPC instead */
-		called_addr.pc = mtp->dpc;
-		called_addr.presence |= OSMO_SCCP_ADDR_T_PC;
-	}
-
 	/* retrieve the SCCP payload (TCAP data) */
 	ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA);
 	if (!ie_data) {

To view, visit change 42684. To unsubscribe, or for help writing mail filters, visit settings.