pespin has uploaded this change for review.

View Change

xua_snm: assert to guard against NULL ptr

This is similarly done for same IE in other functions, so let's do it
here too in order to make coverity happy, and avoid random access ptr
probably ending up in obscure crash.

Fixes: Coverity CID#272994
Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0
---
M src/xua_snm.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/81/28481/1
diff --git a/src/xua_snm.c b/src/xua_snm.c
index 1212162..c7d0d2e 100644
--- a/src/xua_snm.c
+++ b/src/xua_snm.c
@@ -464,6 +464,8 @@
const uint32_t *cong_level = xua_msg_get_u32p(xua, M3UA_IEI_CONG_IND, &_cong_level);
int log_ss = osmo_ss7_asp_get_log_subsys(asp);

+ OSMO_ASSERT(ie_aff_pc);
+
LOGPASP(asp, log_ss, LOGL_NOTICE, "RX SCON(%s) for %s level=%u\n", info_str ? info_str : "",
format_affected_pcs_c(xua, asp->inst, ie_aff_pc), cong_level ? *cong_level : 0);


To view, visit change 28481. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0
Gerrit-Change-Number: 28481
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-MessageType: newchange