fixeria submitted this change.

View Change

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified
s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU

setup_rsp is carefully constructed, but is not actually used.
The f_ConnHdlr_rx_s1ap_from_enb() call falls through to the ? default,
so the test accepts any S1AP PDU and never validates that the S1GW
actually populated the failed-items list correctly.

Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7
Fixes: 47544443 ("s1gw: add TC_e_rab_setup_failure")
---
M s1gw/S1GW_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn
index 6623b1f..43cbe74 100644
--- a/s1gw/S1GW_Tests.ttcn
+++ b/s1gw/S1GW_Tests.ttcn
@@ -507,7 +507,7 @@
setup_rsp := tr_S1AP_RABSetupRsp(g_pars.mme_ue_id, g_pars.idx,
rab_setup_items := omit,
rab_failed_items := tr_E_RABList(item));
- f_ConnHdlr_rx_s1ap_from_enb(s1ap_pdu);
+ f_ConnHdlr_rx_s1ap_from_enb(s1ap_pdu, setup_rsp);

f_ConnHdlr_s1ap_disconnect();
f_ConnHdlr_s1ap_unregister(g_pars.genb_id);

To view, visit change 42342. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7
Gerrit-Change-Number: 42342
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>