Attention is currently required from: dexter.

View Change

8 comments:

• File include/osmo-bts/pcu_if.h:

  • Patch Set #1, Line 26: int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t tlli, uint8_t sapi);

    the function is named pch but we pass a sapi? are you sure this is correct?

• File src/common/bts.c:

  • Patch Set #1, Line 662: static struct msgb *bts_agch_dequeue(struct gsm_bts *bts)

    this can be in a separate commit apparently.

  • Patch Set #1, Line 757:

    unrelated?

  • Patch Set #1, Line 765: if (msg->cb[0])

    I'd love to know what these fields cb[0] and cb[1] are here. Maybe add #define getters for it?

  • Patch Set #1, Line 766: pcu_tx_pch_data_cnf(gt->fn, msg->cb[1], PCU_IF_SAPI_AGCH_DT);

    nice, a _pch_ function where an AGCH sapi is passed. This is obviously wrong.

• File src/common/paging.c:

  • Patch Set #1, Line 737: pcu_tx_pch_data_cnf(gt->fn, pr[num_pr]->u.macblock.tlli, PCU_IF_SAPI_PCH_DT);

    pcu_tx_data_cnf?

• File src/common/pcu_sock.c:

  • Patch Set #1, Line 714: msg->cb[0] = confirm;

    can we add a packed struct for these fields?

  • Patch Set #1, Line 715: msg->cb[1] = gsm_pcu_if_agch_dt->tlli;

    You are assuming unsigned long is 32 bytes or more here (it probably is in most archs).

To view, visit change 34059. To unsubscribe, or for help writing mail filters, visit settings.