Attention is currently required from: neels, dexter.

View Change

7 comments:

• File configure.ac:

  • Patch Set #24, Line 90: PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.4.0)

    So the E1 CCU feature is configurable via `--enable-er-e1-ccu` and is disabled by default, but you're requiring `libosmo{abis,trau}` unconditionally. Maybe depend on these libraries only if the feature is enabled?

• File contrib/jenkins.sh:

  • Patch Set #24, Line 59: PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sanitize"

    You should add `--enable-er-e1-ccu` here, so that the conditional code is also built by Jenkins.

• File contrib/osmo-pcu.spec.in:

  • Patch Set #24, Line 36: 1.3.0

    You require 1.4.0 in `configure.ac`, but 1.3.0 here?

  • Patch Set #24, Line 49: configure

    Do we want to build RPM and DEB packages with `--enable-er-e1-ccu`?

• File src/Makefile.am:

  • Patch Set #24, Line 218: EXTRA_DIST

    Why do you put `.[ch]` files to `EXTRA_DIST`? This is unusual.

• File src/ericsson-rbs/er_ccu_descr.h:

  • Patch Set #24, Line 3: #include <stdint.h>

    missing `<stdbool.h>`

• File src/ericsson-rbs/er_ccu_if.c:

  • Patch Set #24, Line 412: tall_ccu_ctx = ctx;

    Either obtain a child ctx here, or simply use `extern void *tall_pcu_ctx;`.

To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.