Attention is currently required from: falconia.

View Change

2 comments:

• File src/codec/hr_sid_class.c:

  • Patch Set #2, Line 35: for (; byte; byte >>= 1) {

    This is absolutely fine for not so hot code paths, but if this is to be done for each byte of each RTP frame, I would recommend using a look-up table here. It can contain bit count for all 4-bit values, so then you could do:

    ```
    return table[byte >> 4] + table[byte & 0x0f].
    ```

  • Patch Set #2, Line 144: class1_ones = sid_field_ones - class2_ones;

    I am wondering if, in theory, `class2_ones` can be greater than `sid_field_ones`?
    We'll end up with a huge number in this case.

To view, visit change 37558. To unsubscribe, or for help writing mail filters, visit settings.