osmith submitted this change.
deps/Makefile: error if repo _commit is missing
If the _commit variable for a repository is missing (or has a typo), the
update logic silently ignores the repository because "$$($(1)_HEAD)" and
"$($(1)_commit)" both result in empty strings. Give a useful error
message instead.
Change-Id: I99d07a3dda3005c9c5696031bc693d353c5c0e37
---
M deps/Makefile
1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/deps/Makefile b/deps/Makefile
index 17943f9..7dc6659 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -140,6 +140,12 @@
ifeq ($$($(1)_MODIFIED),1)
@echo "WARNING: $(1) skipped because it contains uncommitted modifications!"
else
+ifeq ($($(1)_commit),)
+ @echo
+ @echo "ERROR: missing $(1)_commit!"
+ @echo
+ @exit 1
+endif
ifneq ($$($(1)_HEAD),$($(1)_commit))
@./update.sh "$(1)" "$($(1)_commit)" "$(2)"
endif
To view, visit change 43525. To unsubscribe, or for help writing mail filters, visit settings.