Attention is currently required from: laforge, pespin.
View Change
2 comments:
File src/osmo_ss7_asp.c:
Patch Set #1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb
This function is 90% identical to `m3ua_tcp_cli_read_cb()`.
I would of course like to reduce code duplication.
Suggestions are welcome!
File src/xua_rkm.c:
Patch Set #1, Line 240: M3UA-over-SCTP or M3UA-over-TCP? Can we use asp->cfg.proto maybe?
@laforge@osmocom.org your feedback would be welcome here.
To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Sat, 03 Feb 2024 00:01:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment