Attention is currently required from: pespin, dexter.
Patch set 2:Code-Review -1
View Change
2 comments:
Patchset:
Patch Set #1:
why putting a dot there? To me v11 is totally fine :/
Agreed.
File src/osmobts_sock.c:
Patch Set #2, Line 220: to OsmoBTS
Would be more useful to change this part to `to OsmoBTS/OsmoBSC` or even remove it completely, since it may look confusing to the users running osmo-pcu co-located with osmo-bsc. Plus rename this file to `pcuif_sock.c`.
To view, visit change 34239. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7c70c4d4440fa9885e1efb80e6f2e4e821ac916f
Gerrit-Change-Number: 34239
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Aug 2023 22:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment