Attention is currently required from: laforge, pespin, fixeria.
4 comments:
File src/libsmpputil/smpp_msc.c:
The bad side of using auto-formatting :)
Done
File src/libsmpputil/smpp_smsc.c:
Patch Set #49, Line 985: osmo_stream_srv_link_close(smsc->link);
Then this needs to be investigated further and fixed, it probably means there's a bug.
Indeed, would be nice to dig deeper to understand why changing refcounting breaks tests. I don't see at as a reason to not merge a patch which doesn't change it though - this is clearly outside of the scope for this ticket.
File src/libsmpputil/smpp_smsc.c:
Patch Set #57, Line 767: return -ENOMEM;
I know it's unlikely that msgb_alloc() would return NULL, but still: shouldn't we close the connecti […]
That depends whether we treat memory allocation as recoverable error or not. If it is than one of subsequent calls might succeed if memory pressure was reduced in a meantime. There's nothing wrong with the socket so why would we close it for unrelated error?
Ack
Done
To view, visit change 28849. To unsubscribe, or for help writing mail filters, visit settings.