Attention is currently required from: dexter.
1 comment:
Patchset:
Yes, I am setting PCU_IF_FLAG_SYSMO in osmo-bsc. I do not fully understand why it even exists. […]
Yes, my quick understanding is that the flag is used to signal "direct phy". We can make sure that's the case by checking when osmo-bts sets that flag (eg based on whether it is VTY-configured to use direct phy or not).
IMHO we should add flags or configurations or whatever to describe per-bts which type it is so that osmo-pcu knows what to do. something like an enum with 1 field per l1if type:
{
L1IF_ALL_PCUIF,
L1IF_DIRECT_SYSMO,
L1IF_DIRECT_LC15,
L1IF_DIRECT_O2CG,
L1IF_DIRECT_RBS,
}
To start with, perhaps simply rename s/PCU_IF_FLAG_SYSMO/PCU_IF_FLAG_DIRECT_PHY/ if that makes sense.
In any case, now that we have these "if (fl1h)" conditional blocks, I wonder whether it really makes sense to have the #ifef ENABLE_DIRECT_PHY around there. It may make sense to get rid of them in the common paths and simply make the check at runtime.
To view, visit change 34575. To unsubscribe, or for help writing mail filters, visit settings.