Attention is currently required from: pespin, fixeria.
6 comments:
File src/osmobts_sock.c:
Patch Set #3, Line 113: if (the_pcu->phy.l1if_close_pdch && bts->trx[trx].fl1h) {
not criticial but less confusing: I'd first check for f1h and finally for l1if_close_pdch. […]
(see my other comments.)
File src/osmobts_sock.c:
Patch Set #5, Line 115: bts->trx[trx].fl1h = NULL;
After another looks, this looks even worse, because you are not skipping setting fl1h to NULL if phy […]
l1if_close_pdch exists when the_pcu->phy_ops (see above). I think it should be ok.
File src/pcu_l1_if.cpp:
Patch Set #5, Line 218: the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr,
guard this with "if (the_pcu->phy_ops->l1if_pdch_req)". Similar for all other function calls.
It checks for the_pcu->phy_ops. That should be enough since all callbacks except l1if_init_phy must be populated. I used the pointer to l1if_pdch_req to guard this before but this is no longer required. On all other function I also only use the_pcu->phy_ops now.
File src/pcu_l1_if_phy.c:
Patch Set #5, Line 15: struct llist_head list;
You can really put this inside ops too, and get rid of l1if_phy_entry.
When I do that then the ops can not be declared as static const inside the module because the list head would have to writable. I have kept the l1if_phy_entry list now but the only member is the list head and the pointer to ops.
Patch Set #5, Line 18: const char *name;
this can really be in li1f_phy_ops and assign the pointer statically, there's no need to have it sep […]
Done
Patch Set #5, Line 27: bool singleton;
this too can be set in phy_ops. […]
Done
To view, visit change 31341. To unsubscribe, or for help writing mail filters, visit settings.