osmith submitted this change.

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified

contrib/jenkins.sh: check osmo_bts_has_feature use

Make sure we don't check against bts->model->features instead of
bts->features by accident.

Related: SYS#5922, OS#5538
Change-Id: I47eef4978aaf9e20fc00a3ca029568671bd09d8d
---
M contrib/jenkins.sh
1 file changed, 11 insertions(+), 0 deletions(-)

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 189eb2c..53b30bf 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -27,6 +27,17 @@
 
 verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
 
+# Check for wrong use of osmo_bts_has_feature (OS#5538)
+bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*->model->features' | grep -v 'jenkins.sh')" || true
+if [ -n "$bts_features_wrong_use" ]; then
+	set +x
+	echo
+	echo "ERROR: Don't use osmo_bts_has_feature with bts->model->features. Use bts->features instead."
+	echo
+	echo "$bts_features_wrong_use"
+	exit 1
+fi
+
 export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
 export LD_LIBRARY_PATH="$inst/lib"
 export PATH="$inst/bin:$PATH"

To view, visit change 27922. To unsubscribe, or for help writing mail filters, visit settings.