Attention is currently required from: pespin.
View Change
1 comment:
File src/libmsc/msc_a.c:
Patch Set #1, Line 962: osmo_timer_del(&msc_a->cc.assignment_request_pending);
is it fine calling osmo_timer_del for a timer object which may not have gone through osmo_timer_setu […]
yes, as long as it was nul initialized, which msc_a always is. (it checks for active != 0)
To view, visit change 37272. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0f1e1a551aed545b555b9f236fc5967b1e4cc940
Gerrit-Change-Number: 37272
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jun 2024 19:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment