fixeria has uploaded this change for review.

View Change

s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs

We use a tuple of {MmeUeId, EnbUeId, RABId} to register and lookup
E-RAB FSMs in the registry.  Using RABId alone is wrong (because
it's not a globally unique ID) and will never yield anything.

Because of this bug the E-RAB FSMs were never terminated properly.
This was found thanks to the ttcn3-s1gw-test and remained unnoticed
so far because in test_e_rab_release() we still have this TODO:

  %% TODO: make sure that the E-RAB FSM has been terminated

We'll need to add some E-RAB introspection API to implement this.

Change-Id: Ic737e7b0c08562ecfd641ce4e3c2f27c26f8560e
Fixes: 935a0f02 "{sctp,s1ap}_proxy: employ E-RAB FSMs"
---
M src/s1ap_proxy.erl
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/41/38141/1

diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl
index f28ff56..1df1518 100644
--- a/src/s1ap_proxy.erl
+++ b/src/s1ap_proxy.erl
@@ -269,7 +269,7 @@
                               value = Content}, S) ->
     %% poke E-RAB FSM
     #'E-RABItem'{'e-RAB-ID' = ERABId} = Content,
-    case dict:find(ERABId, S#proxy_state.erabs) of
+    case erab_fsm_find(ERABId, S) of
         {ok, Pid} ->
             ok = erab_fsm:erab_release_req(Pid);
         error ->
@@ -287,7 +287,7 @@
                               value = Content}, S) ->
     %% poke E-RAB FSM
     #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = Content,
-    case dict:find(ERABId, S#proxy_state.erabs) of
+    case erab_fsm_find(ERABId, S) of
         {ok, Pid} ->
             ok = erab_fsm:erab_release_rsp(Pid);
         error ->

To view, visit change 38141. To unsubscribe, or for help writing mail filters, visit settings.