Attention is currently required from: jolly.

Patch set 5:Code-Review +1

View Change

2 comments:

• File src/core/osmo_io_uring.c:

  • Patch Set #5, Line 56: #define IOFD_URING_MAXIMUM_SIZE 32768

    I'm still wondering where is this maximum specified? Is it a kernel hardcoded value? liburing? Do we have a liburing define for this?

  • Patch Set #5, Line 112: /* 32768 is the maximum number of entries the Kernel can handle. */

    Better move this comment to where IOFD_URING_MAXIMUM_SIZE is defined.

To view, visit change 40782. To unsubscribe, or for help writing mail filters, visit settings.