Attention is currently required from: Hoernchen, laforge.
View Change
2 comments:
File src/logging.c:
Patch Set #6, Line 107: memset(tmp_level, 100, osmo_log_info->num_cat);
Done
NOT DONE YET
Patch Set #6, Line 156: return (level < log_level_lookup_cache[mapped_subsys]) ? false : true;
This is precisely the inverted "when not to log" approach used by the existing check and I am reusin […]
Just a hint, leave it as you wish.
To view, visit change 30633. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d
Gerrit-Change-Number: 30633
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: Hoernchen <ewild@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Mon, 19 Dec 2022 18:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment