Attention is currently required from: pespin.

View Change

3 comments:

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #2, Line 440: conn->end.codec = mgcp_codec_find_same(conn, found_same_codec_opposite);

    Ah I see what you mean, you are looking the codec in each conn list. […]

    The data is not duplicated. Its just that each endpoint holds two connections and each connections has a codec list. This is the list that had been issued by the call agent during CRCX/MDCX. We can not put both into one list since then we would lose the info which side supports what.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #4, Line 509: return;

    so you decided to drop the return code while still logging an ERROR. […]

    The caller is not doing anything meaningful with it but maybe it is better to drop the packet than sending it with a wrong PT.

  • Patch Set #4, Line 1166: mgcp_patch_pt(conn_dst, msg);

    all this code path failing looks buggy. […]

    Technically nothing has changed but I can see mgcp_send() might need some refactoring.

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.