Attention is currently required from: Timur Davydov.
2 comments:
File CommonLibs/Threads.cpp:
Patch Set #1, Line 58: char *err_str = NULL;
wrong indentation
Patch Set #1, Line 59: #if defined(__GLIBC__) && defined(_GNU_SOURCE)
Can we move all this into a helper function above so it can be reused?
char *strerror_buf(int err, char *buf, size_t buf_size)
{
#if defined(__GLIBC__) && defined(_GNU_SOURCE)
char *err_str = NULL;
err_str = strerror_r(err, buf, sizeof(buf));
#else
if (strerror_r(err, buf, sizeof(buf)) == 0) {
err_str = buf;
} else {
snprintf(buf, sizeof(buf), "Unknown error %d", err);
err_str = buf;
}
#endif
return err_str;
}
To view, visit change 42199. To unsubscribe, or for help writing mail filters, visit settings.