Attention is currently required from: neels, pespin, fixeria.
6 comments:
Patchset:
I see there is a lot of confusion on the backward compatibility topic. I will now look at the BTS patches.
I have fixed stuff in other places, so I will push the patch set again. I will get to the remaining comments later.
File include/osmocom/pcu/pcuif_proto.h:
Patch Set #19, Line 279: uint8_t pgroup;
> And AFAIR, yes, it can be bigger than 255. […]
I have checked the spec for RSL it is indeed only one octet, see 3GPP TS 08.58 section 9.3.14
File include/osmocom/pcu/pcuif_proto.h:
Patch Set #18, Line 43: PCU_IF_SAPI_PCH_DT
The patch for `osmo-bts.git` is already in Gerrit (currently WIP to avoid merging before this one). […]
I have seen your BTS patch. Thanks. I will test this today. I didn't look at the tests yet.
File src/bts.cpp:
Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
If we go this way (backwards compatibility), we would have to keep both `PCU_IF_MSG_DATA_CNF` and `P […]
Ack
File src/pcu_l1_if.cpp:
Patch Set #19, Line 298: pgroup
I think this is where the confusion comes from. […]
Thats wired.
Patch Set #19, Line 771: } else {
According to above block (like 752), only PCU_IF_VERSION and 0x0a are allows to reach here. […]
Thats true. I thought that I had remove it though...
To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.