Attention is currently required from: dexter, laforge.
6 comments:
File pySim/global_platform/__init__.py:
Patch Set #7, Line 20: import io
unused import?
(hm, why doesn't the linter complain?)
Patch Set #7, Line 772: Prefixed(Int8ub, GreedyBytes
This is basically LV structure. Given that it's used several times and can be useful in other places, maybe define it somewhere? Wait, actually it's already defined in pyosmocom:
```
# here we collect some shared / common definitions of data types
LV = Prefixed(Int8ub, HexAdapter(GreedyBytes))
```
It's a bit different, but I assume it works the same way?
Patch Set #7, Line 824: ('--from-hex
why not using `type=is_hexstr` here?
load_parser.add_argument('--from-hex', help='load from hex string')
load_parser.add_argument('--from-file', help='load from binary file')
If these params are mutually-exclusive (only one of these must be supplied), please create a group using `add_mutually_exclusive_group()` and make that group `mandatory=True`.
formatting
Patch Set #7, Line 835: with open(opts.from_file, 'rb') as f:
BTW, argparse does have: https://docs.python.org/3/library/argparse.html#filetype-objects
To view, visit change 37454. To unsubscribe, or for help writing mail filters, visit settings.