Attention is currently required from: dexter.

Patch set 27:Code-Review +1

View Change

4 comments:

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */

    I don't understand.

    typo: errornous-> erroneous

  • Patch Set #25, Line 53: static void tx_release_req(struct hnbgw_context_map *map)

    Do you have any ideas where? This is a helper function that is called from to location of this FSM t […]

    We'd probably want to add a hnbgw_iu.c or alike, but ok, let's keep it here for now.

  • Patch Set #25, Line 424: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg,

    In practice the message don't change ths size, but in theory they might either shrink or grow. […]

    ack

  • Patch Set #25, Line 627: static int handle_rab_release(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message)

    It does belong to here. […]

    Ok let's leave it here for now.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.