Attention is currently required from: jolly, laforge, pespin.

View Change

1 comment:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 68: inout charstring, CallParameters, ASCI_Event;

    As can be seen from the existing code, we tend to define strings as named constants and then send/match these constants rather than typing strings here and there. This is clearly better because this eliminates problems due to possible typos in strings.

    ```
    COORD.send("CALL_READY");
    ...
    COORD.receive("C[E]LL_READY");
    ```

    So personally I really like the idea of using (valueless) enums and I vote for them.

    The problem with string typos can easiler be solved by definiting const string variables, or enums and converting them enum2str() when sending.

    The problem is that... There is no `enum2str()` in TTCN-3.

    What I don't like in the current patch revision is that we end up having testsuite specific stuff in a common module: `ASCI_Event` in this case. IMO, it's cleaner if each testsuite (`MSC_Tests`, `MSC_Tests_Iu`, and the new `BSC_Tests_ASCI`) would define its own COORD port and the related enums/types internally. This may not apply to the `MSC_Tests_Iu`, because it's mostly re-using the test logic from `MSC_Tests`, but I don't see the need for the `MSC_Tests[_Iu]` to have access to ASCI specific port messages.

To view, visit change 33979. To unsubscribe, or for help writing mail filters, visit settings.