pespin submitted this change.

View Change

Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved
Fix uninitialized return value

Caught by gcc 14.2.1:

/osmo-remsim/src/client/user_simtrace2.c:153:16: warning: ‘rc’ may be used uninitialized [-Wmaybe-uninitialized]
153 | return rc;
| ^~
/home/pespin/dev/sysmocom/git/osmo-remsim/src/client/user_simtrace2.c:128:13: note: ‘rc’ was declared here
128 | int rc;
| ^~

Change-Id: If90892ff6e00be38cea6f6d3161bf2386351bb21
---
M src/client/user_simtrace2.c
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c
index 3bc32e2..65d4cde 100644
--- a/src/client/user_simtrace2.c
+++ b/src/client/user_simtrace2.c
@@ -143,6 +143,7 @@
break;
case SIMTRACE_MSGT_BD_CEMU_CONFIG:
/* firmware confirms configuration change; ignore */
+ rc = 0;
break;
default:
LOGCI(ci, LOGL_ERROR, "unknown simtrace msg type 0x%02x\n", sh->msg_type);

To view, visit change 39022. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: If90892ff6e00be38cea6f6d3161bf2386351bb21
Gerrit-Change-Number: 39022
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>