lynxis lazus submitted this change.

View Change

Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved
sip.c: permit early media with both 183 and 180

So far we only attempted to extract SDP (and hence enable early media)
when receiving a status code 183. However, SDP can also be provided
with 180, see for example https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Codecs-and-Media/Early-Media/vs-183-vs-Early-Media_7143480/

Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Closes: OS#6559
---
M src/sip.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sip.c b/src/sip.c
index 99bab9f..3e262f9 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -82,7 +82,7 @@
return;

/* Extract SDP for session in progress with matching codec */
- if (status == 183)
+ if ((status == 180 || status == 183) && sip->sip_payload && sip->sip_payload->pl_data)
sdp_extract_sdp(leg, sip, false);

LOGP(DSIP, LOGL_INFO, "leg(%p) is now progressing.\n", leg);

To view, visit change 38039. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Gerrit-Change-Number: 38039
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: keith <keith@rhizomatica.org>