Attention is currently required from: laforge.

View Change

2 comments:

• File pySim/filesystem.py:

  • Patch Set #1, Line 1043: __get_rec_len

    I'm not following your argument here. […]

    I have put the double underscore to make the method as private. Also I don't think that the double underscore is exclusively reserved for python internal stuff. At least I haven't read that anywhere yet.

    I found an interesting article about the underscore topic:
    https://medium.com/python-explainers/single-and-double-underscores-in-python-explained-63a805ef34db

  • Patch Set #1, Line 1266: return b2h(filter_dict(build_construct(self._construct, abstract_data, self._get_size(total_len))))

    TransRecEF registeres the cdm2 command-set form TransparentEF, yes. It will call lchan. […]

    I still not seeing entirely through here. I thought TransRecEF were transparent files with multiple fixed length records. But its actually the other way around? I was expected to get the record oriented command set but I get the command set for transparent files but with multiple records in the JSON struct.

    In any case, I have tested it and it seems to work fine. The files get updated properly. Also the unittests seem to have coverage, so I think everything should be ok here.

To view, visit change 38195. To unsubscribe, or for help writing mail filters, visit settings.