Attention is currently required from: lynxis lazus.

View Change

2 comments:

• File src/sgsn/gprs_gmm.c:

  • Patch Set #1, Line 1978: Create tlvp_val16be

    `tlvp_val16be` is already there, did you mean `tlvp_val16le`?

  • Patch Set #1, Line 1979: osmo_swab16(tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));

    I would avoid calling `tlvp_val16be()` and then swapping bytes.
    `tlvp_val16be()` is calling `osmo_load16be()` internally, so you can do:

    ```
    osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS))
    ```

To view, visit change 40653. To unsubscribe, or for help writing mail filters, visit settings.