Attention is currently required from: fixeria, osmith, pespin.

View Change

8 comments:

• File src/sccp2sua.c:

  • Patch Set #3, Line 444: * \param[in] iei xUA information element identifier of source data */

    `\returns`?

  • Patch Set #3, Line 455: one byte

    you say "one", but actually allocating two?

  • Patch Set #3, Line 466: LSB first

    use `osmo_store16le()` here?

  • Patch Set #3, Line 554: ptr_addr + 1 + ptr_value + 2

    Seeing more and more pointer arithmetic, I am wondering if we could have a packed struct with a union inside maybe? I am not familiar with the protocol and not sure if this approach fits here, but I believe it would improve code readability a lot.

  • Patch Set #3, Line 557: LSB first

    use `osmo_load16le()` here?

  • Patch Set #3, Line 809: ptr_opt + (ptr_opt_is_long ? 1 : 0) > msg->tail

    btw, what if the value equals `msg->tail`? I am not 100% sure, but it looks like you need to make sure that it's less than `msg->tail` (not equal) and that it actually fits: `... > msgb->tail - (ptr_opt_is_long ? 2 : 1)`.

  • Patch Set #3, Line 1415: 254

    but you say 255 in the comment above?

• File tests/xua/xua_test.c:

  • Patch Set #3, Line 504: {

    `>>`

To view, visit change 34467. To unsubscribe, or for help writing mail filters, visit settings.