Attention is currently required from: arehbein, daniel, pespin.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);

    > simply never read from that fd and just keep it open there so no ICMP errors are sent […]

    I agree, it probably make sense to

    • keep the current code for the sink as-is for this patch
    • consider developing/testing/merging a patch that disables reading from that socket altogether. I would be surprised if there would be ICMP unreachable errors for a socket that's open. So it should work and reduced the load on the osmocom processes as they don't have to receive back each of those packets just to discard it.

To view, visit change 34743. To unsubscribe, or for help writing mail filters, visit settings.