Attention is currently required from: manawyrm, tnt.

View Change

1 comment:

• File src/octoi/frame_rifo.c:

  • Patch Set #1, Line 117: if ( fn < rifo->next_out_fn - FRAMES_PER_FIFO )

    I'm not really following here. so the previous check was whether we try to insert a frame number that is too large. Your new check is for a frame number that is too small ("min_in_fn").

    But the way how you nested the new if clause, it means -ERANGE is only returned if it's both larger than max_in_fn and smaller than "min_in_fn", i.e. never?

    I guess we shold define a frame_rifo_min_in_fn() function similar to frame_rifo_max_in_fn() and then have an or-statement here if it's either less than min_in_fn or greater than max_in_fn?

To view, visit change 27716. To unsubscribe, or for help writing mail filters, visit settings.