lynxis has uploaded this change for review.
tcap_as_loadshare: remove outdated counter tcap:asp:failed
The counter counted all cases when rejecting the TCAP message,
but does not differentiate between the multiple failures.
Related: SYS#8283
Change-Id: I390cc5b0bd4500ed8f1d674fb13ac5dced5f7c9b
---
M src/ss7_as.c
M src/ss7_as.h
M src/tcap_as_loadshare.c
3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/44086/1
diff --git a/src/ss7_as.c b/src/ss7_as.c
index d000125..d2b6081 100644
--- a/src/ss7_as.c
+++ b/src/ss7_as.c
@@ -144,7 +144,6 @@
[SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS] = {"tcap:loadshare:success","Successful ASP selection for a TCAP Begin message (loadshare-tcap)" },
[SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE] = {"tcap:loadshare:failure","Could not find a valid ASP for a TCAP Begin message (loadshare-tcap)" },
[SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" },
- [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" },
[SS7_AS_CTR_TCAP_SESS_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry. (loadshare-tcap)" },
[SS7_AS_CTR_TCAP_SESS_HIT] = { "tcap:session:hit", "A non-starting TCAP message (Continue, End, Abort) hit a session entry, (loadshare-tcap)" },
#endif /* WITH_TCAP_LOADSHARING */
diff --git a/src/ss7_as.h b/src/ss7_as.h
index f869240..27c56e4 100644
--- a/src/ss7_as.h
+++ b/src/ss7_as.h
@@ -71,7 +71,6 @@
SS7_AS_CTR_TCAP_LOAD_SHARE_SUCCESS,
SS7_AS_CTR_TCAP_LOAD_SHARE_FAILURE,
SS7_AS_CTR_TCAP_ASP_FALLBACK,
- SS7_AS_CTR_TCAP_ASP_FAILED,
SS7_AS_CTR_TCAP_SESS_MISS,
SS7_AS_CTR_TCAP_SESS_HIT,
#endif /* WITH_TCAP_LOADSHARING */
diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c
index 4842c23..bee3bfd 100644
--- a/src/tcap_as_loadshare.c
+++ b/src/tcap_as_loadshare.c
@@ -734,7 +734,6 @@
goto out_free_sua;
}
- rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK);
}
/* Don't create an entry for an End */
}
@@ -749,9 +748,6 @@
break;
}
out_free_sua:
- if (rc == -ENOKEY)
- rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED);
-
/* RFC3868 4.7.3: "If an ASP is not available, the SG may generate (X)UDTS "routing failure",
* if the return option is used."
* See also ITU Q.714 4.2 */
To view, visit change 44086. To unsubscribe, or for help writing mail filters, visit settings.